the metal piece that holds the door open in the hinge is broke, do I have to take the door off to change it, it looks like a bugger to change with the door on, anyone ever change one of theses or do you just live with it broken?

 

No.
Just take the hinge off and put a new one on. You will need to block up the door, another pair of hands will make it easer